[SCR] Missile Defense Mk2 (v2.28 - 17.12.11)

[A5PECT]

EDIT: Anyone else getting SMTP errors while posting??

Yes.

[Sam L.R. Griffiths]

Just look into any ".adv" vanilla turret script. They all reference it.

I have already done that for the problematic Vanilla scripts.

Breaking this functionality for MARS would amount to setting the flag in it's global config array.
You should find the location in the setup and/or the read config/laser data script.

Are you saying that MD Mk2 is basically a limited version of (or add-on for) MARS? Or shares configuration with MARS?

EDIT: From an early post this does not appear to be the case, so I go back to my original question... which script in MD Mk2 needs to be edited to disable weapon switching.

For other scripts like MEFOS - I dunno.

MEFOS is extremely simplified - it switches between user configured sets as far as I can tell.

[Gazz]

Are you saying that MD Mk2 is basically a limited version of (or add-on for) MARS? Or shares configuration with MARS?

No. Not even close. I'm talking about MARS.
Since you want to disable weapon switching for your EES/CWP thing, you'll have to do this for more than one turret script.
I was just telling you how.
(edited the last post, too)

As long as this is a clearly labeled feature of EES/CWP, I don't care.
It's the player's choice in the end and I never made any attempt to make my scripts unaccessible by packing them or deleting any comments. Much to the contrary...

I think there's about half a dozen turret scripts that switch weapons.

[Sam L.R. Griffiths]

Just look into any ".adv" vanilla turret script. They all reference it.
...
The clean solution to disable this for Mk2 would be to provide your own launcher scripts and attach them to the in-game commands - the same way I did it for Mk2.
That way nothing is overwritten and scripts can be installed / uninstalled separately.

Ok, problem solved (I think - further testing necessary)...

From the looks of things the "vanilla" turret behaviour is to set turret commands to "Attack Target" by default (with EES 2.4 I fixed the switching for this command - which appears to be only used by the AI).

With MD Mk2 it looks like the other ADV commands come into play and so they needed to be patched as per already done for the "Attack Target" command.

Thanks for the help

[Gazz]

From the looks of things the "vanilla" turret behaviour is to set turret commands to "Attack Target" by default

No.
Vanilla ships run a mix of Attack Target and Missile Defense.

[Sam L.R. Griffiths]

Just look into any ".adv" vanilla turret script. They all reference it.
...
The clean solution to disable this for Mk2 would be to provide your own launcher scripts and attach them to the in-game commands - the same way I did it for Mk2.
That way nothing is overwritten and scripts can be installed / uninstalled separately.

Ok, problem solved (I think - further testing necessary)...

Nope... problem not solve despite patching the relevant scripts.

EDIT: Dug deeper and confirmed it, MD Mk2 (reg) did need to be modified to prevent the single laser shinanagons - plugin.gz.missile.def.mk2.

Now for more testing...

[Gazz]

EDIT: Dug deeper and confirmed it, MD Mk2 (reg) did need to be modified to prevent the single laser shinanagons - plugin.gz.missile.def.mk2.

That is not true.
It's a quick an unnecessary hack which screws with the player's ability to install / uninstall scripts selectively.
I can't stop you from doing it, though, so *shrug*

[Sam L.R. Griffiths]

EDIT: Dug deeper and confirmed it, MD Mk2 (reg) did need to be modified to prevent the single laser shinanagons - plugin.gz.missile.def.mk2.

That is not true.
It's a quick an unnecessary hack which screws with the player's ability to install / uninstall scripts selectively.
I can't stop you from doing it, though, so *shrug*

To use the reg version of MD Mk2 AND to stop the single laser problem it *is* required. To do as you suggest would effectivly involve writing a whole new version of MD Mk2 (reg) rather than the simple *tweak* to one of your scripts to avoid the issue entirely.

Don't get me wrong, I am not criticising your implementation but it is necessary to get MD Mk2 to work correctly with EES/CWP.

[TrixX]

Don't get me wrong, I am not criticising your implementation...

You may not be criticising it but you are missing the point.

...but it is necessary to get MD Mk2 to work correctly with EES/CWP.

No it's not. Altering the way EES works to match Gazz's script would make them play nice and not lock the player to using the Roger LS Not Quite Working version of it.

[Sam L.R. Griffiths]

Don't get me wrong, I am not criticising your implementation...

You may not be criticising it but you are missing the point.

...but it is necessary to get MD Mk2 to work correctly with EES/CWP.

No it's not. Altering the way EES works to match Gazz's script would make them play nice and not lock the player to using the Roger LS Not Quite Working version of it.

Right first off... the tweaks to the base script I am proposing is to basically tell the vanilla weapon switching to take a long run and jump and settle for what-ever weapons are equiped (the vanilla weapon switching algorithms are borked as we all know). That is the only change to get it working with EES. The problem is not with Gazz's script nor EES (or CWP - same issues) but the MCSI command, so avoiding it's use is the only option.

Secondly, I am not missing the point... it is a simple patch to get it to work nicely with EES/CWP and is an low CPU alternative to replacing the hard-coded weapon switching with Gazz's better (and more CPU intensive from what I gather) implementation.

[TrixX]

Ok, I'll keep this simple for you as you have yet again failed to comprehend what others are trying to say.

You are altering someone elses script without permission to do so. You are then expecting others to download your altered version to work with EES (not CWP that's Litcube's business). That is not a solution most people will be happy with. You took EES from Litcube without permission and ran with it. I don't see how this is much different other than you are openly arguing with the original script writer who even gave you a method of fixing your script to play nice with ALL other scripts.

Third the stock weapon switching works absolutely fine when certain parameters are met. We stumbled upon this a while back when weapon testing Alpha 0.5.4. If all weapons of the same type are the same size it chooses the correct weapon for the target about 95% of the time.

[Sam L.R. Griffiths]

You are altering someone elses script without permission to do so. You are then expecting others to download your altered version to work with EES (not CWP that's Litcube's business).

The problem is universal to both EES and CWP (both currently follow the same conventions for equipping turrets and only differ on selection criteria) with regards to modifying a script without the author's permission AND expecting others to download it you are way off track (see below).

You took EES from Litcube without permission and ran with it. I don't see how this is much different other than you are openly arguing with the original script writer who even gave you a method of fixing your script to play nice with ALL other scripts.

WRT EES as far as I was aware LitCube was ok with it, there have been no objections from LitCube wrt my updates and in fact LitCube has shown positive support for my changes. As LitCube was the original author I can only take that as a form of approval. At the time I released the patches, there was no thread covering EES and my later taking responsibility for the redistributions of EES was purely because I was doing alot of updates to the base scripts (and there was no existing thread for it). As far as I am concerned the baseline concept is still LitCube's Intelectual Property the additions are predominently based on feedback and ideas from the wider community.

Third the stock weapon switching works absolutely fine when certain parameters are met. We stumbled upon this a while back when weapon testing Alpha 0.5.4. If all weapons of the same type are the same size it chooses the correct weapon for the target about 95% of the time.

WRT MD Mk2, all I am proposing is a patch (nothing more or less) and for EES/CWP that will avoid the issues with weapon mods. There are known concerns over the stock weapon commands selection commands when used with weapon add-on mods more specifically... I have had issues with ships changing loadouts to one gun and engaging in combat that way without loading additional weapons. This may be fine for missile interception but it messes up ship on ship combat.

I have made the modifications in my local copy of Gazz's (reg) script and have been testing it out before I send it to Gazz for consideration as a lower CPU cost alternative to his by far superior ADV version for those that want to use it with weapon mods and EES/CWP.

[Jack08]

WRT EES as far as I was aware
LitCube was ok with it, there have been no objections from LitCube wrt my updates and in fact LitCube has shown positive support for my changes. As LitCube was the original author I can only take that as a form of approval. At the time I released the patches, there was no thread covering EES and my later taking responsibility for the redistributions of EES was purely because I was doing alot of updates to the base scripts (and there was no existing thread for it). As far as I am concerned the baseline concept is still LitCube's Intelectual Property the additions are predominently based on feedback and ideas from the wider community.

Highlighted in Red is an incorrect fact
Highlighted in Yellow is an incorrect fact that hasn't been publicly announced

Assumptions are bad for ones health

[Sam L.R. Griffiths]

[OT]

Highlighted in Red is an incorrect fact
Highlighted in Yellow is an incorrect fact that hasn't been publicly announced

Assumptions are bad for ones health

That sounds like a threat, and a direct indication of a personal attack. Rather than you and TrixX continuing this blatant campaign of terror in open forum against me, I think it is up to LitCube to speak for him/her self (in private via PM) if they have an issue.[/OT]

@ Gazz : Please excuse this diversion from your thread's topic, my original point still stands from my testing to date wrt the Regular version. However, I am looking to investigate your ADV version and the relative performance impact on my game. I am hoping it is going to be good enough.

[TrixX]

[OT]That sounds like a threat, and a direct indication of a personal attack. Rather than you and TrixX continuing this blatant campaign of terror in open forum against me, I think it is up to LitCube to speak for him/her self (in private via PM) if they have an issue.[/OT]

Campaign of Terror

TERROAR TERROAR TERROAR

Since when were you on Obama's military staff? The spin you are placing on this is akin to that of a $million political campaign

Apologies for the derail Gazz, but I must agree with Gazz's solution rather than yours Roger as at the end of the day it gives compliance without needing to download modified versions of exactly the same script.

[Sam L.R. Griffiths]

[OT]

Since when were you on Obama's military staff? The spin you are placing on this is akin to that of a $million political campaign

Your are not funny, and your insults are getting beyond a joke now. You call it spin, it is the down right blatant obvious truth... as seems evident from your persisting comment on it in open forum. I have tried to divert this discussion to PM. Enough is Enough![/OT]

WRT Gazz's implementation there is no direct issue, my proposed idea is merely a low CPU load alternative to the ADV for the cases where the vanilla weapon swapping is truely borked.

The main reason for my interest is someone's recommendation, but what I was unaware of till earlier today is that they were using the ADV version (somthing I was resisting due to concerns about added script loading).

[TrixX]

Check your PM's, BTW that wasn't and insult above, you were calling wolf at a rabbit.

[Sam L.R. Griffiths]

[OT]

Check your PM's, BTW that wasn't and insult above, you were calling wolf at a rabbit.

Maybe not, but in the context of previous posts and personal observations it was perceived as such.[/OT]

For further information on what the primary trigger for the MCSI Weapon Swapping issues see this post by LitCube. Before that post it was not a known issue to me.

[Gazz]

Version 2.25 released.

There is only one scriptversion now.
The desired degree of lasery switchiness is assigned with an AL Plugin.

This can also disable MD Mk2 in case you'd like to get hit with missiles more often.

Also a required compatibility upgrade for OOSR v2.

[Mizuchi]

So will this be automagically included with a new (slight) MARS revision, or...?

How might one go about installing it with MARS already installed, given that MARS includes it?