Will the warehouse mining bugs be fixed one day ?

The place to discuss scripting and game modifications for X Rebirth.

Moderators: Moderators for English X Forum, Scripting / Modding Moderators

Browser_ice
Posts: 485
Joined: Sun, 5. Feb 06, 17:15
x4

Post by Browser_ice » Sat, 3. Mar 18, 22:36

I set up a warehouse. Assigned it 5 mining ships and after 30 min or so, I see one ship is just flying around doing nothing when there is plenty to mine. My log search shows only one log even and it was when I assigned it to the warehouse (bulk assignment of all ships).

I will wait longer to see if it does something or not.

Ships are:
- one small gaz miner
- one small bulk miner (this is the one just traveling around)
- one large gaz miner
- one large bulk miner
- one large anything miner (scaldis)

[added comments]
My Small Bulk Miner finaly picked up some ore and started doing his job. I don't know why it took a while for him to start.

I accidently goofed up and had to restart the game, therefore creating a new log. So far it seams to be going good. I will still let it run for a while and see what happens. If this is fixed, I will be happy to give this game another try. Usage of warehouse is such a big part of the gameplay but it was ruining my game not being able to mine properly.
Steam X-Superbox, XR, playing X4
WIndows-10
Intel I7-3770
16Gb Memory
Nvgidia GTX-1060

Sparky Sparkycorp
Moderator (English)
Moderator (English)
Posts: 8074
Joined: Tue, 30. Mar 04, 12:28
x4

Post by Sparky Sparkycorp » Sun, 4. Mar 18, 01:02

Nice one. Thanks for the reply and for testing.

Andy_MB
Posts: 72
Joined: Fri, 24. Jul 15, 17:47
x4

Post by Andy_MB » Sun, 4. Mar 18, 08:03

Hi. For 4.30 :
"WarehouseMinersFix"

or hire

..aiscripts\mining.ship.station.xml

Code: Select all

<diff xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <replace sel="//set_value[@exact='[this.ship.cargo.{$ware}.free, $homebase.cargo.{$ware}.target].min']/@exact">[this.ship.cargo.{$ware}.free, $homebase.cargo.{$ware}.target - $homebase.cargo.{$ware}.count].min</replace>
  <replace sel="//do_if[@value='$iswarehouse']//append_to_list[@name='$unloadlist']/@exact">[$tempware, [this.ship.cargo.{$tempware}.count, $homebase.cargo.{$tempware}.target - $homebase.cargo.{$tempware}.count].min]</replace>
</diff>
_____________

Browser_ice
Posts: 485
Joined: Sun, 5. Feb 06, 17:15
x4

Post by Browser_ice » Sun, 4. Mar 18, 18:14

Andy_MB wrote:Hi. For 4.30 :
"WarehouseMinersFix"

or hire

..aiscripts\mining.ship.station.xml

Code: Select all

<diff xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <replace sel="//set_value[@exact='[this.ship.cargo.{$ware}.free, $homebase.cargo.{$ware}.target].min']/@exact">[this.ship.cargo.{$ware}.free, $homebase.cargo.{$ware}.target - $homebase.cargo.{$ware}.count].min</replace>
  <replace sel="//do_if[@value='$iswarehouse']//append_to_list[@name='$unloadlist']/@exact">[$tempware, [this.ship.cargo.{$tempware}.count, $homebase.cargo.{$tempware}.target - $homebase.cargo.{$tempware}.count].min]</replace>
</diff>
translation of the site link:
Title: WarehouseMinersFix (Fixed warehouse miners)
Author: eliseeff
Version of the mod: 1.02
Short Description: Correction of script errors attributed to the miners' warehouse, because of which they overflow the storage in excess of the established limits in version 4.30.

Egosoft, you are aware of this error ?
Steam X-Superbox, XR, playing X4
WIndows-10
Intel I7-3770
16Gb Memory
Nvgidia GTX-1060

Browser_ice
Posts: 485
Joined: Sun, 5. Feb 06, 17:15
x4

Post by Browser_ice » Sat, 10. Mar 18, 23:32

I thought the issues were fixed but I am discovering something that looks like an issue I had before. I had renable some MODs since last reply.

My warehouse is not displaying some wares in its trade window causing the mining ship to not be able to transfer their mined wares to the warehouse.

I noticed this when I found I had a bunch of mining ships always full and always docking at my warehouse. I tried to transfer directly to the warehouse one of those product (using a mining ship that was not assigned to warehouse) but the wares was not showing up in the list of available wares to transfer.

I have MODs but none of them are related to mining or trading.

So I do not know what to do.

Should I disable and try the whole thing again from scratch ? I kind of don't want to do it. I had restarted so many times before because of issues.

Instead, I am trying this warehouse fix in the above reply.

By the way I did noticed this error message below that is happening quite often. I did not look for where it is in the script.
  • [General] 63608.97 ======================================
    [=ERROR=] 63608.97 Error in AI script mining.ship.station on entity 0x8af7: Custom trade failed, and here is why:
    [General] 63608.97 ======================================
    [General] 63608.97 ======================================
    [=ERROR=] 63608.97 Error in AI script mining.ship.station on entity 0x8af7: Custom trade failed, and here is why:
    [General] 63608.97 ======================================
    [General] 63608.97 ======================================
    [=ERROR=] 63608.97 Error in AI script mining.ship.station on entity 0x8af7: Custom trade failed, and here is why:
    [General] 63608.97 ======================================
Steam X-Superbox, XR, playing X4
WIndows-10
Intel I7-3770
16Gb Memory
Nvgidia GTX-1060

Browser_ice
Posts: 485
Joined: Sun, 5. Feb 06, 17:15
x4

Post by Browser_ice » Sat, 10. Mar 18, 23:47

No, I still have the same issue. I even noticed that when they mining ship dock at my warehouse, there are no exchanges of cargo lifters. It docks, then a few seconds later it undocks. After that it either says it will min again or go in free mining mode.

I am going to test it again, at same location. Restarting from scratch, disabling all mods.
Steam X-Superbox, XR, playing X4
WIndows-10
Intel I7-3770
16Gb Memory
Nvgidia GTX-1060

Sparky Sparkycorp
Moderator (English)
Moderator (English)
Posts: 8074
Joined: Tue, 30. Mar 04, 12:28
x4

Post by Sparky Sparkycorp » Sun, 11. Mar 18, 00:42

Browser_ice wrote: My warehouse is not displaying some wares in its trade window causing the mining ship to not be able to transfer their mined wares to the warehouse.

I noticed this when I found I had a bunch of mining ships always full and always docking at my warehouse.
I think this is more of a oddity rather than a bug as it has always been this way. There's some related info on the wiki under the heading "setting up a mining hub".
Browser_ice wrote: I tried to transfer directly to the warehouse one of those product (using a mining ship that was not assigned to warehouse) but the wares was not showing up in the list of available wares to transfer.
I'm not sure why that would occur. Do at least one of either the ship or Warehouse have cargolifters?

Browser_ice
Posts: 485
Joined: Sun, 5. Feb 06, 17:15
x4

Post by Browser_ice » Sun, 11. Mar 18, 15:08

I read your wiki reference. I cannot say if that is what happen. I will still test it. I have started building my warehouse last time I saved a game.

However, I need more infos on the following wiki sentence:
5. Once you've edited the storage allocation or sell/buy prices for added wares you can not reset them! You have to click the X to remove the ware, and re-add to let the Manager control those values again (Grey text).

Does this apply to any change actions below ?
- changing either buying/selling price value
- changing storage value
- switching between buying/selling

In other words, when the warehouse takes in account what ever wares that I told it to is at the first time we set up the volume/price/trade-action once added ? Any changes done after is disregarded ?
Steam X-Superbox, XR, playing X4
WIndows-10
Intel I7-3770
16Gb Memory
Nvgidia GTX-1060

User avatar
eliseeff
Posts: 255
Joined: Wed, 26. Jan 05, 17:17
x4

Post by eliseeff » Sun, 11. Mar 18, 18:43

Browser_ice wrote:My warehouse is not displaying some wares in its trade window causing the mining ship to not be able to transfer their mined wares to the warehouse.
This can happen if the storage of your warehouse is damaged. Try to repair the warehouse.
Browser_ice wrote:
  • [General] 63608.97 ======================================
    [=ERROR=] 63608.97 Error in AI script mining.ship.station on entity 0x8af7: Custom trade failed, and here is why:
    [General] 63608.97 ======================================
    [General] 63608.97 ======================================
    [=ERROR=] 63608.97 Error in AI script mining.ship.station on entity 0x8af7: Custom trade failed, and here is why:
    [General] 63608.97 ======================================
    [General] 63608.97 ======================================
    [=ERROR=] 63608.97 Error in AI script mining.ship.station on entity 0x8af7: Custom trade failed, and here is why:
    [General] 63608.97 ======================================
Such errors constantly appear in the debuglog because of an improperly compiled unload list. In 4.30 sctript checking all the space allocated for the current resource, instead of free space in the warehouse.

This is what fixes my fix.

$homebase.cargo.{$tempware}.target = all the space allocated for the $tempware resource

...is replaced by:

$homebase.cargo.{$tempware}.target - $homebase.cargo.{$tempware}.count = free part of space, allocated for the $tempware resource

Similarly (earlier in the script) when assigning the $neededAmount variable:

$homebase.cargo.{$ware}.target ==> $homebase.cargo.{$ware}.target - $homebase.cargo.{$ware}.count

Post Reply

Return to “X Rebirth - Scripts and Modding”