Bug with the BPH script

[fchopin]

Bug with the BPH script.

BPH ships do not buy 125 MW shields, GPSGs, BPSGs and other weapons when home base is Equipment Dock or Trading Station.

[Hicky]

There was me just thinking they were lazy sods. I suffer with the same problem with 25MW, GPPC and GPSG.

[fchopin]

I was testing my BPH last night and found that they buy food products but do not buy the big weapons like B and GPSGs and also 125 MW shields.

[Spark]

I suppose you checked the race settings?
Then maybe it has something to do with treshold percentages? Like with the SDS? With 2 weapons bought the cargohold is barely filled.
Just guessing.

[fchopin]

I suppose you checked the race settings?
Then maybe it has something to do with treshold percentages? Like with the SDS? With 2 weapons bought the cargohold is barely filled.
Just guessing.

I don't see what the race settings have to do with this, they buy food products from the same race so why should they not buy shields and Big weapons?

125MW Shields, BHEPTs, GHEPTs, BPSGs, GPSGs always come in 2s because thats the maximum hold.

[Spark]

Ok, just for the heck of it, why don't you set other races can trade(...) to "yes" and see what happens.....

And SDS has some algorithm - I think BPH has it too - which calculates if it's worthwhile to make the trip, calculated with cargohold, stock and a few other variabels.

[fchopin]

I will have to try this tonight, i am working now.

But even if the AI do come and trade it is my own BPH ship that i want to see buying.

[KarlHemmings]

From the BPH read me
"5. If resources are rare, BPH freighters favour the factory with the greatest number of products. They will not start a trading run for anything less than 4 products available, the reason being by the time the Freighter gets there the factory will more than likely be sold out anyway."

If they will not start a run with less than 4 products available there are certain products they can never buy.....

[thanakar]

I have the same problems getting BPH traders to buy the high end goods. In my view the problem is the small stock number compared to the price of the item. The BPH trader doesn't feel the trade is worth the trip so they just don't go. I have no problem getting them to hunt down missiles and 1 mw shields.

[fchopin]

If they will not start a run with less than 4 products available there are certain products they can never buy.....

But that meens they will never buy 125MW shields and other weapons because they only stock 2.

[Spark]

Thus a bug.
Can't try this out myself though, I don't have high end factories.
But I don't think it's a bug. It seems, that these scripts share the same libs, coming from the UT script. I suspect, that this specific behaviour is a part of these libs, which would make sense.
And if UT buys shields, so would BPH. That's why I stress you look at the race settings of your factories.
But.... You might be right!
Ok, back to work for me too. Till tonight.
Spark out.

[fchopin]

Question for Developers and Dev people.
Is this the problem why the BPH ships do not buy 125MW shields and Weapons that stock only 2 per products?

Will the BPH ship buy a product with less than 4 in stock?

[Firedancer]

Thus a bug.
Can't try this out myself though, I don't have high end factories.
But I don't think it's a bug. It seems, that these scripts share the same libs, coming from the UT script. I suspect, that this specific behaviour is a part of these libs, which would make sense.
And if UT buys shields, so would BPH. That's why I stress you look at the race settings of your factories.
But.... You might be right!
Ok, back to work for me too. Till tonight.
Spark out.

should be fairly easy to fix.... I guess the solution would be to script them use variable thresholds, based on default price of a ware.... e.g. I'd not be happy if my merchant ship heads out to buy 4 energy cells either.... it should be like a small table... default price 1-20.... buy 100 minimum, price 21-50... buy 50 minimum.....etc... and at prices >100000 it might also go for a single one.... I guess a simple if/elseif with 3-4 ranges should be plenty.

[ticaki]

Question for Developers and Dev people.
Is this the problem why the BPH ships do not buy 125MW shields and Weapons that stock only 2 per products?

Will the BPH ship buy a product with less than 4 in stock?

Answer for the ppl

1.Yes 2.No
i will see, what i can do
mhm... add a

Code: Select all

minValue = 0
skip if 5 < (max_cargo_space / 2) 
 minValue = 5

will do it

Greets ticaki

[thanakar]

Well, something just happened that make me think there was no bug. One of my BPH Traders is going after a BPPC! I just hope he can get to the station before it is sold. The equipment dock is two sectors away and he is only level 4

[fchopin]

Question for Developers and Dev people.
Is this the problem why the BPH ships do not buy 125MW shields and Weapons that stock only 2 per products?

Will the BPH ship buy a product with less than 4 in stock?

Answer for the ppl

1.Yes 2.No
i will see, what i can do
mhm... add a

Code: Select all

minValue = 0
skip if 5 < (max_cargo_space / 2) 
 minValue = 5

will do it

Greets ticaki

Thank's ticaki, I will wait for further developments.

[thanakar]

Question for Developers and Dev people.
Is this the problem why the BPH ships do not buy 125MW shields and Weapons that stock only 2 per products?

Will the BPH ship buy a product with less than 4 in stock?

Answer for the ppl

1.Yes 2.No
i will see, what i can do
mhm... add a

Code: Select all

minValue = 0
skip if 5 < (max_cargo_space / 2) 
 minValue = 5

will do it

Greets ticaki

Thank's ticaki, I will wait for further developments.

Are we supposed to add this ourselves to the script (if so which file) or is this a future planned update?

[Spark]

Back from work.
Fchopin, I certainly am glad, I left the possibility open, that you were right

[fchopin]

Back from work.
Fchopin, I certainly am glad, I left the possibility open, that you were right

Thank's Spark but i wish i ws wrong.

[fchopin]

Are we supposed to add this ourselves to the script (if so which file) or is this a future planned update?

I think there will be a future update!