v710b537045 - station auto-name (build evolution) incomplete - working as intended

[donzi]

It's common to have a new station evolved during the building process; in this case it starts out as another solar power plant in the sector.
Specifically, it's correctly suffixed with "II" while identified as a solar power plant.

As the station evolves into the recycling role, the name is auto-adjusted as expected, however the "II" remains.
This should be "I" since it's my first and only scrapper in the sector.



A save with the station at the solar stage is available via PM.

[donzi]

FWIW, player rename of the wrongly auto-named station is cosmetic only, auto-rename is oblivious to player 'corrective' renames.. hence will sync & name as it previously interpreted existing stations.

Makes sense, but more or less means it's probably best to roll with what the game names stations while the issue exists to avoid additional work.

EG: Although that Scrapper II the game named should be I, it will fill in with a Scrapper I if making an new fac in the sector IIRC (will ignore player manually naming existing, wrongly named II to I)

[CBJ]

You're right, and I can see why it happens. However the numbering is only intended to maintain the uniqueness of the auto-generated name, not to be an accurate reflection of the exact number of stations.

For example, if you have three Solar Power Plant stations and the one numbered "II" is removed, then "III" is not renumbered. The gap is not filled unless another Solar Power Plant is created. Obviously the game could do this renumbering, but we opted not to as it could be more confusing than helpful to players if their other stations suddenly get renumbered.

Basically the game makes the smallest amount of change that it can when checking whether a station needs to be renamed, and this is a side-effect of that. Admittedly it's not a side-effect that was entirely intentional, but I'm reluctant to change it because it gives the player a slightly better chance of recognising which station it was before it was renamed, even if it only works in cases where the new name and number doesn't conflict with a different station.

[donzi]

Thank you for the information & explanation, CBJ.

I understand and waffled on posting it since I figured the core purpose was being met, but wasn't sure the extent of it's intended functionality.

..so, figured may as well put it here while I was thinking about it. (and before I forgot)

You all made the better choice IMO. The initial unique sequenced name(s) are perfect.

Eventhough I haven't implemented my own station naming system in X4 so far, the auto generated names would have a limited life if I had to work with more than a few stations.